Differences
This shows you the differences between two versions of the page.
|
ii:labs:05:tasks:03 [2022/01/17 15:04] radu.mantu |
ii:labs:05:tasks:03 [2025/01/11 20:05] (current) florin.stancu |
||
|---|---|---|---|
| Line 1: | Line 1: | ||
| - | ==== 03. [??p] Reverse SSH ==== | + | ==== 03. [50p] Adding & changing features ==== |
| - | TODO | + | When you want to add a new feature to your project, you should first develop it in a [[https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches|branch]]. A branch is a named copy of the deltas that comprise your codebase up to a certain point. By adding commits to this copy, you won't interfere with other people trying to do their own thing. Note that a branch can be created from any other branch, including //master//. |
| - | <note tip> | + | {{ :ii:labs:05:branches.png?700 |}} |
| - | In the following commands //[localhost]// means that the command should be executed on your computer, //[gcloud]// on the Google Cloud VM, and //[fep]// on fep.grid.pub.ro. | + | |
| - | </note> | + | Eventually, you will want to merge your commits with the original branch. This can be done in two ways: ''git merge'' or ''git rebase''. Here is a [[https://www.atlassian.com/git/tutorials/merging-vs-rebasing|discussion]] on which is better. You should probably read it at some point. In this lab we will be focusing on ''git rebase'' since it is more interactive and provides many functionalities that you will need when trying to get your changes accepted by the maintainer / reviewer. |
| + | |||
| + | === [30p] Task A - Add token flag === | ||
| + | |||
| + | For example, the feature that we'll want to add to [[:ii:labs:04|the music bot]] is a command line argument parser that will accept an optional ''%%-t, --token [TOKEN]%%''. We suggest that you use [[https://docs.python.org/3/howto/argparse.html|argparse]]. In absence of this token, you will fall back to fetching it from the environment variable. | ||
| <code bash> | <code bash> | ||
| - | # create the .ssh directory (if not already there) | + | # first, create a new branch from HEAD |
| - | [gcloud]$ mkdir -p ~/.ssh | + | $ git branch feature |
| - | # print out your fep.grid.pub.ro public key and copy it | + | # next, switch to the feature branch |
| - | [fep]$ cat ~/.ssh/id_rsa.pub | + | $ git checkout feature |
| - | # configure your fep.grid.pub.ro public key on gcloud instance | + | # check that the branch you are on is actually feature and not master |
| - | [gcloud]$ vim ~/.ssh/authorized_keys | + | $ git branch |
| + | * feature | ||
| + | master | ||
| + | |||
| + | # edit and test your script | ||
| + | # argparse should add a default '--help' option | ||
| + | |||
| + | # commit changes and push them to the remote feature branch | ||
| + | # first push means that the branch needs to be created (follow the command's hints) | ||
| + | $ git add ${BOT_PY_FILENAME} | ||
| + | $ git commit -s | ||
| + | $ git push | ||
| </code> | </code> | ||
| + | |||
| + | At this point, you have created a separate //feature// branch, added a (hopefully) working CLI argument parser, and pushed the newly created branch to your //remote//. When working with other people, now would be a good time to create a [[https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request|Pull Request]] (PR). This is a request to the maintainer of the project to pull your //feature// branch, check that everything is working, and give feedback if changes need be made. If changes are indeed requested, all you have to do is address them in a new commit which you'll push into your //feature// branch. The PR will be updated automatically. Once the reviewer gives his ok, your changes will be applied to the //master// branch. | ||
| + | |||
| + | Since this is your repository and you have to deal with integrating the changes, let's use ''git rebase'' to do just that. | ||
| <code bash> | <code bash> | ||
| - | # create a reverse ssh tunnel from your computer to the cloud instance | + | # switch back to the master branch |
| - | [localhost]$ ssh -T -N -R 43210:localhost:22 ${GCLOUD_USERNAME}@${GCLOUD_IP} | + | $ git checkout master |
| - | # show tcp listeners (bound ports, processes, etc.) | + | # apply the extra commits from feature onto master |
| - | [gcloud]$ sudo netstat -tlpn | + | $ git rebase feature |
| - | Active Internet connections (only servers) | + | Successfully rebased and updated refs/heads/master. |
| - | Proto Recv-Q Send-Q Local Address Foreign Address State PID/Program name | + | |
| - | tcp 0 0 127.0.0.1:43210 0.0.0.0:* LISTEN 1931/sshd: ........ | + | |
| - | tcp 0 0 127.0.0.53:53 0.0.0.0:* LISTEN 448/systemd-resolve | + | |
| - | tcp 0 0 0.0.0.0:22 0.0.0.0:* LISTEN 893/sshd: /usr/sbin | + | |
| - | # test that the reverse ssh tunnel works | + | # remember to push the newly integrated changes to remote |
| - | [gcloud]$ ssh ${LOCALHOST_USERNAME}@localhost -p 43210 | + | $ git push |
| + | </code> | ||
| - | # connect from fep.grid.pub.ro to your localhost via gcloud instance | + | //"Wait. That's it?"// Well... yeah. Luckily, you did not have any conflicts with //master//. If you did, ''git rebase'' would have told you exactly where those conflicts were located. Moreover, it would have modified your files to look something like this: |
| - | [fep]$ ssh -J ${GCLOUD_USERNAME}@${GCLOUD_IP} ${LOCALHOST_USERNAME}@localhost -p 43210 | + | <code> |
| + | <<<<<<< HEAD | ||
| + | Changes made to master since branch. | ||
| + | ======= | ||
| + | Changes made to feature since branch. | ||
| + | >>>>>>> feature | ||
| </code> | </code> | ||
| + | |||
| + | In order to resolve the conflicts, you would have to remove the lines with //%%"<<<"%%//, //%%"==="%%//, //%%">>>"%%// and rewrite the conflicting code so that it incorporates both your changes, and those already pushed to //master//. Finally, mark the conflicts as resolved by re-adding the files, and continue your rebase. | ||
| + | |||
| + | <code bash> | ||
| + | # re-add files with solved conflicts | ||
| + | $ git add ${CONFLICTING_FILES} | ||
| + | |||
| + | # continue the rebase process | ||
| + | $ git rebase --continue | ||
| + | |||
| + | # alternatively, you can just give up and go back to how things were (no harm done) | ||
| + | $ git rebase --abort | ||
| + | </code> | ||
| + | |||
| + | This part is now optional, but it would be nice to clean up and delete the //feature// branch both locally and remotely. All changes that //feature// held are now part of //master//, so what is it good for anymore? | ||
| + | |||
| + | <code bash> | ||
| + | # delete feature branch on remote (origin) | ||
| + | $ git push -d origin feature | ||
| + | |||
| + | # delete feature branch locally | ||
| + | $ git branch -d feature | ||
| + | </code> | ||
| + | |||
| + | === [20p] Task B - Edit older commits === | ||
| + | |||
| + | In the beginning we said that ''git rebase'' is interactive and fun. But we never had the chance to show it. Remember in the previous exercise when we added the COPYING file and the copyright notice to the //Python// script? Let's say that the reviewer changed his mind about this and now wants us to create two separate commits. One for the script and one for the copy of GPLv3. How would we go about solving this problem? | ||
| + | |||
| + | [[https://ocw.cs.pub.ro/courses/_media/ii/labs/05/tasks/rebase-demo.gif|{{ :ii:labs:05:rebase-demo.gif?700 |}}]] | ||
| + | <html><center><i> Click GIF to maximize. </i></center></html> | ||
| + | |||
| + | Why, using ''git rebase'', of course! | ||
| + | |||
| + | <code bash> | ||
| + | # take a look at the commits we have so far | ||
| + | # #1: adding the bot | ||
| + | # #2: adding the GPL license | ||
| + | # #3: adding the argument parser | ||
| + | $ git log | ||
| + | |||
| + | # launch git rebase in interactive mode (-i) | ||
| + | # and tell it we want to revisit the last 2 commits relative to our head | ||
| + | $ git rebase -i HEAD~2 | ||
| + | </code> | ||
| + | |||
| + | After running ''git rebase -i'', it should have opened your default CLI file editor (same as with ''git commit''). Notice that you have two lines that look something like this, followed by multiple lines describing __commands__. | ||
| + | |||
| + | <code> | ||
| + | pick 4864b9d Added GNU General Public License. | ||
| + | pick 37d816c Added cli argument parser for token. | ||
| + | </code> | ||
| + | |||
| + | Once we save this file, **git** will parse it's non-comment contents line by line and execute the __commands__ on the given commits, in the order that they were specified. The **pick** command just selects a certain commit. By swapping lines, you will tell git to **pick** commits in a different order, thus reordering them on your current branch. Deleting a line will effectively delete the changes made by that commit in the current repository. What we're interested in, however, is the **edit** command. This command tells **git** to stop the rebasing process at that specific commit and let you make changes to it before proceeding. | ||
| + | |||
| + | <code bash> | ||
| + | # HEAD is now on commit 4864b9d which we marked for edit | ||
| + | |||
| + | # revert the changes made with this commit ==> files no longer added in staging area | ||
| + | $ git reset HEAD~1 | ||
| + | |||
| + | # check the status of the files; see how COPYING and the Python script are now untracked | ||
| + | $ git status | ||
| + | |||
| + | # add the files one at a time; and commit them separately | ||
| + | $ git add COPYING | ||
| + | $ git commit -s | ||
| + | |||
| + | $ git add ${BOT_SCRIPT} | ||
| + | $ git commit -s | ||
| + | |||
| + | # from one commit, we now created two; continue the rebasing process | ||
| + | $ git rebase --continue | ||
| + | |||
| + | # check to see that two new commits were indeed created | ||
| + | $ git log | ||
| + | |||
| + | # push this changes to remote, thus rewriting history | ||
| + | $ git push --force | ||
| + | </code> | ||
| + | |||
| + | Once again, force pushing a different commit history onto the //master// branch is a bad idea if working with other people. But doing it onto your own branch is not only fine, but sometimes necessary in order to address the reviewer's requests. | ||
| + | |||
| + | |||
